yahoo-eng-team team mailing list archive

[OpenStack Infra <1563028@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/298419
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=6664fb27af2218c411230f91b8e23e72845cbf2a
Submitter: Jenkins
Branch:    master

commit 6664fb27af2218c411230f91b8e23e72845cbf2a
Author: Amrith Kumar <amrith@xxxxxxxxxx>
Date:   Mon Mar 28 16:10:53 2016 -0400

    Address change in Route v2.3
    
    Routes v2.3 which just came out included a change (see the LP bug
    referenced below) that caused py27 to fail.
    
    At issue is that Routes<2.3 allowed both
    
        submapper.connect(route_name, route_path), and
        submapper.connect(route_path).
    
    In 2.3, you were required to provide both route_name and
    route_path. This change adds a route_name to support both Routes < 2.3
    and Routes == 2.3.
    
    Change-Id: I8738d4dcac2cc37b727767ba614fab4339758e22
    Closes-Bug: 1563028


** Changed in: trove
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1563028

Title:
  Routes version 2.3 broke the way we register routes

Status in neutron:
  Fix Released
Status in Trove:
  Fix Released

Bug description:
  Routes v2.3 which just came out included this change

  https://github.com/bbangert/routes/commit/0a417004be7e2d950bdcd629ccf24cf9f56ef817

  which changed submap.connect() in a way that broke the way Trove
  registers routes.

  We now need to provide a routename and a path as independent
  arguments.

  I tried to make sense of the documentation at
  http://routes.readthedocs.org/en/v2.3/setting_up.html#submappers and
  got nowhere in a hurry, but reading the code for connect() provided a
  possible solution.

  This will likely need to go to stable/mitaka as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1563028/+subscriptions