← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1268480] Re: assertTrue(isinstance()) in tests should be replace with assertIsInstance()

 

Reviewed:  https://review.openstack.org/262530
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=29e9cab8c2a4507aaccae5804cba21400200f9ce
Submitter: Jenkins
Branch:    master

commit 29e9cab8c2a4507aaccae5804cba21400200f9ce
Author: Shuquan Huang <huang.shuquan@xxxxxxxxxxx>
Date:   Wed Dec 30 22:43:49 2015 +0800

    Change assertTrue(isinstance()) by optimal assert
    
    Some of tests use different method of assertTrue(isinstance(A, B)) or
    assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
    B) provided by testtools.
    
    Change-Id: Ie98c1aec65281fa1784070ce76e472caca7cfc47
    Closes-bug: #1268480


** Changed in: tempest
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to anvil.
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in anvil:
  Fix Committed
Status in Barbican:
  Fix Released
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  In Progress
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in ironic-python-agent:
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Monasca:
  Fix Released
Status in Murano:
  Fix Released
Status in networking-powervm:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-heatclient:
  Fix Committed
Status in python-keystoneclient:
  Fix Released
Status in python-manilaclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in python-openstackclient:
  Fix Committed
Status in OpenStack SDK:
  Fix Released
Status in python-rackclient:
  Fix Committed
Status in Rally:
  In Progress
Status in Sahara:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/anvil/+bug/1268480/+subscriptions


References