← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1547406] Re: eslint should be upgraded

 

Hello Jeffrey,

seems that this was done on https://review.openstack.org/#/c/282249 and
its already merged. I forgot to attach the bug number to the patch as I
was removed from the bug on a mistake.

Ill take the bug and set it as fix releases, sorry for the invonvenience
and thanks for the work done!

** Changed in: horizon
     Assignee: Jeffrey Augustine (ja224e) => Itxaka Serrano (itxakaserrano)

** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1547406

Title:
  eslint should be upgraded

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The eslint package is frozen to version 1.2.1, which was released the
  20th of August of 2015.

  The newer versions (last 1.x version is 1.10.3) fixes a lot of issues
  and a lot of checks which are not working correctly or which are
  totally missing:

  http://eslint.org/docs/rules/operator-linebreak.html

  Which is activated on eslint-config-openstack but was never checked:
  https://github.com/openstack/horizon/blob/master/horizon%2Fstatic%2Fhorizon%2Fjs%2Fhorizon.quota.js#L103

  
  Also it provides a new config flag "--max-warnings" which would be incredibly useful so we can put a limit to the number of warning that we get and enforce a new check.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1547406/+subscriptions


References