yahoo-eng-team team mailing list archive

[OpenStack Infra <1571342@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/306838
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e23ef5bd23bd800420d145a11ceb903ec4c52400
Submitter: Jenkins
Branch:    master

commit e23ef5bd23bd800420d145a11ceb903ec4c52400
Author: Kahou Lei <kahou82@xxxxxxxxx>
Date:   Sun Apr 17 08:00:20 2016 -0700

    Fix confusing naming in ldap EnableEmuMixin.
    
    In keystone/common/ldap/core.py, the get_all() method of EnabledEmuMixIn is
    using "tenant" as the return object. This is misleading as the core method
    is not using as project only but also other identity or resources (such as
    user and group). We should change to name to be more generic to avoid
    confusion.
    
    Change-Id: I53a7eb22539697e16ac9893daf59506483345f9e
    closes-bug: 1571342


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1571342

Title:
  Misleading variable naming is used in ldap driver

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  In keystone/common/ldap/core.py, the EnabledEmuMixIn get_all() method
  is using "tenant" as the return object. This is misleading as this
  method is not using as project only but also other identity resources
  (such as user and group). We should rename the variables to be more
  generic to avoid confusion.

  https://github.com/openstack/keystone/blob/master/keystone/common/ldap/core.py#L1921-L1932

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1571342/+subscriptions