yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/315397
Committed: https://git.openstack.org/cgit/openstack/vitrage/commit/?id=a3aeb31a63092569c4b2e465009fd99db8755ac4
Submitter: Jenkins
Branch:    master

commit a3aeb31a63092569c4b2e465009fd99db8755ac4
Author: sharat.sharma <sharat.sharma@xxxxxxxxxxxxxxxxxx>
Date:   Thu May 12 13:37:17 2016 +0530

    Changed assertTrue(isinstance) to assertIsInstance()
    
    Change-Id: I87fb09fb56ed886cb7d2a398e5c719b7f381ce80
    Closes-Bug: #1268480


** Changed in: vitrage
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to anvil.
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in anvil:
  Invalid
Status in Barbican:
  Fix Released
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  In Progress
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Monasca:
  Fix Released
Status in Murano:
  Fix Released
Status in networking-powervm:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-heatclient:
  Invalid
Status in python-keystoneclient:
  Fix Released
Status in python-manilaclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in python-openstackclient:
  Fix Committed
Status in OpenStack SDK:
  Fix Released
Status in python-rackclient:
  Fix Committed
Status in Rally:
  In Progress
Status in Sahara:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released
Status in Vitrage:
  Fix Released
Status in zaqar:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/anvil/+bug/1268480/+subscriptions