yahoo-eng-team team mailing list archive

[Kirill Zaitsev <kzaitsev@xxxxxxxxxxxx>]

Public bug reported:

Recently a commit landed in horizon, that changed inheritance order of
Mixins.
https://github.com/openstack/horizon/commit/4c33d2d40cac592385f7bcfbc106c379d7b70020
The change itself is ok, however this now means, that any class
inherited from ModalFormMixin should have an init without parameters.

This change broke murano-dashboard since we inherit from both formtools wizard and ModalFormMixin.
here is an example of the errors we get http://paste.openstack.org/show/497387/

It might be a good idea to allow *args, **kwargs in ModalBackdropMixin's
init method

** Affects: horizon
     Importance: Undecided
     Assignee: Kirill Zaitsev (kzaitsev)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1582816

Title:
  ModalBackdropMixin imposes empty init method

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  Recently a commit landed in horizon, that changed inheritance order of
  Mixins.
  https://github.com/openstack/horizon/commit/4c33d2d40cac592385f7bcfbc106c379d7b70020
  The change itself is ok, however this now means, that any class
  inherited from ModalFormMixin should have an init without parameters.

  This change broke murano-dashboard since we inherit from both formtools wizard and ModalFormMixin.
  here is an example of the errors we get http://paste.openstack.org/show/497387/

  It might be a good idea to allow *args, **kwargs in
  ModalBackdropMixin's init method

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1582816/+subscriptions