yahoo-eng-team team mailing list archive

[OpenStack Infra <1582816@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/317628
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bb1547c8abcc0d0d3dc4a3199e8e8bd1b5527c12
Submitter: Jenkins
Branch:    master

commit bb1547c8abcc0d0d3dc4a3199e8e8bd1b5527c12
Author: Kirill Zaitsev <kzaitsev@xxxxxxxxxxxx>
Date:   Tue May 17 19:59:40 2016 +0300

    Add *args, **kwargs to ModalBackdropMixin's init method
    
    Before this change ModalBackdropMixin called super(...).__init__()
    without arguments. This imposed restrictions on what classes this
    mixin could have been mixed into, i.e. only classes, that do not accept
    any parameters.
    This proved to be a problem for murano-dashboard, since it uses this
    mixin (indirectly through ModalFormMixin) and mixes it into a class,
    that accepts parameters to it's init method.
    This change allows to use ModalBackdropMixin with classes that have
    init methods with parameters.
    
    Change-Id: I6155476738021b784ef7e643c968f1d784b15906
    Closes-Bug: #1582816


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1582816

Title:
  ModalBackdropMixin imposes empty init method

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Recently a commit landed in horizon, that changed inheritance order of
  Mixins.
  https://github.com/openstack/horizon/commit/4c33d2d40cac592385f7bcfbc106c379d7b70020
  The change itself is ok, however this now means, that any class
  inherited from ModalFormMixin should have an init without parameters.

  This change broke murano-dashboard since we inherit from both formtools wizard and ModalFormMixin.
  here is an example of the errors we get http://paste.openstack.org/show/497387/

  It might be a good idea to allow *args, **kwargs in
  ModalBackdropMixin's init method

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1582816/+subscriptions