← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1161144] Re: admin role must be called "admin"

 

Reviewed:  https://review.openstack.org/123741
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ce5fb26bf5f431f0cdaa6860a732338db868a8fb
Submitter: Jenkins
Branch:    master

commit ce5fb26bf5f431f0cdaa6860a732338db868a8fb
Author: Paul Karikh <pkarikh@xxxxxxxxxxxx>
Date:   Tue Sep 30 14:53:21 2014 +0400

    Remove admin role name 'admin' hardcode
    
    Because of hardcoding name as the 'admin' was impossible to
    use administrative panel with a custom administrative role name.
    This fix replaces hardcoding the name of the administrative role
    with RBAC policy check.
    
    DocImpact
    Related commit: https://review.openstack.org/#/c/123745/
    Change-Id: I05c8fc750c56f6f6bb49a435662e821eb0d6ba30
    Closes-Bug: #1161144


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1161144

Title:
  admin role must be called "admin"

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The admin panel hardcodes the name of admin role as "admin".  A line
  like this exists in dashboards/admin/dashboard.py,
  dashboards/admin/instances/panel.py and
  dashboards/admin/overview/panel.py

      permissions = ('openstack.roles.admin',)

  I'm unable to call the name of the role admin since my keystone is
  integrating with a corporate LDAP that I don't completely control.

  Can the name of the admin role be configurable?

  There is a related bug in django_openstack_auth:
      https://github.com/gabrielhurley/django_openstack_auth/issues/28

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1161144/+subscriptions