← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1554791] Re: Horizon should use upper-constraints in testing

 

Reviewed:  https://review.openstack.org/290203
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=315958aab8273cd2dbfdd617b173d5c063a88948
Submitter: Jenkins
Branch:    master

commit 315958aab8273cd2dbfdd617b173d5c063a88948
Author: Richard Jones <r1chardj0n3s@xxxxxxxxx>
Date:   Wed Mar 9 11:30:20 2016 +1100

    Use upper-constraints in tox test environments
    
    Recently OpenStack introduced a mechanism to specify a constrained
    "working set" of packages that are "guaranteed" to produce a working
    OpenStack environment. This pinning of packages limits the more
    broadly-defined requirements.txt which is managed by
    global-requirements.
    
    This patch modifies our tox test environment to use upper-constraints
    and explictly removes those requirements from the "venv" tox
    environment that is used by some commands in infra.
    
    Change-Id: I84582370e139fc5812bc85ae5341f7f9c8b93ff5
    Closes-Bug: 1554791


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1554791

Title:
  Horizon should use upper-constraints in testing

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Recently OpenStack introduced a mechanism to specify a constrained
  "working set" of packages that are "guaranteed" to produce a working
  OpenStack environment. This pinning of packages limits the more
  broadly-defined requirements.txt which is managed by global-
  requirements. Even though it pins package versions, it is called
  "upper-constraints".

  We should include those constraints in our test runs.

  A mechanism exists to allow constraints to be overridden for specific
  patches by using Depends-On to a constraints update, allowing testing
  of new constraints.

  Given enough test coverage in the constraints updates (to be addressed
  in a separate patch to the gate jobs for that project) this would have
  allowed Horizon to detect that the recent heatclient update broke
  Horizon, but also would have allowed the Horizon gate to continue
  unaffected by the new heatclient update (because we would have been
  pinned to a previous, working version).

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1554791/+subscriptions


References