← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1486607] Re: tenants seem like they were able to detach admin enforced QoS policies from ports or networks

 

Reviewed:  https://review.openstack.org/217092
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4ec6932c93764fd7731928f1faa24b6c88fa9493
Submitter: Jenkins
Branch:    master

commit 4ec6932c93764fd7731928f1faa24b6c88fa9493
Author: Tong Li <litong01@xxxxxxxxxx>
Date:   Tue Sep 15 17:23:42 2015 -0400

    Respond negatively to tenant detachment of enforced QoS policies
    
    Currently when the tenant attempts to detach an enforced QoS policy
    for a port or network set by admin, the attempt fails but the API
    feedback indicates that it was successful.  This change will
    fix the API response so the failure is accurately signalled
    to the tenant.
    
    Co-Authored-By: litong01 <litong01@xxxxxxxxxx>
    Co-Authored-By: gong yong sheng <gong.yongsheng@xxxxxxxxxxx>
    Co-Authored-By: Nate Johnston <Nate_Johnston@xxxxxxxxxxxxxxxxx>
    Co-Authored-By: Margaret Frances <margaret_frances@xxxxxxxxxxxxxxxxx>
    
    Change-Id: I977feecc6cce378abc1e6092afbaf9f2681b2ec6
    Closes-bug: #1486607


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1486607

Title:
  tenants seem like they were able to detach admin enforced QoS policies
  from ports or networks

Status in neutron:
  Fix Released

Bug description:
  NOTE: Even if the API responds with "ok" to the port update, it's not really changing the admin enforced policy, we should just provide a better
  error / response code.

  If the CSP is using manually tagging specific tenant networks to
  follow specific qos profiles, a tenant could use

  neutron port-update <port-id> --no-qos-policy

  or

  neutron net-update <net-id> --no-qos-policy

  It will seem like if the port or net was correctly updated, but it
  isn't. We can lower the importance of this bug to low/medium.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1486607/+subscriptions


References