yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #52628
[Bug 1525913] Re: vmwareapi get vcenter cluster
Reviewed: https://review.openstack.org/257674
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=621191f1d6a6c3f98966069dafac8ca6701f8567
Submitter: Jenkins
Branch: master
commit 621191f1d6a6c3f98966069dafac8ca6701f8567
Author: linbing <hawkerous@xxxxxxxxx>
Date: Thu Jun 16 03:57:13 2016 -0700
VMware: Fix bug of TypeError when getting reference of VCenter cluster is None.
* When get VCenter of all cluster reference and return None, it's a
NoneType, and could not be iterable, so it will cause error like
:“TypeError: 'NoneType' object is not iterable ”.
* This patch add the situation of cluster reference is None, and will
return an empyt list.
Closes-Bug: #1525913
Change-Id: Ifcf0e1edf378f239030a27e40d5bed436876858b
** Changed in: nova
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1525913
Title:
vmwareapi get vcenter cluster
Status in OpenStack Compute (nova):
Fix Released
Bug description:
In liberty nova/virt/vmwareapi/vm_util.py
def get_cluster_ref_by_name(session, cluster_name):
"""Get reference to the vCenter cluster with the specified name."""
all_clusters = get_all_cluster_mors(session)
for cluster in all_clusters:
if (hasattr(cluster, 'propSet') and
cluster.propSet[0].val == cluster_name):
return cluster.obj
when all_cluster is None,this code may cause error:TypeError: 'NoneType' object is not iterable,and nova-computer would't up
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1525913/+subscriptions
References