← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1259292] Re: Some tests use assertEqual(observed, expected) , the argument order is wrong

 

Reviewed:  https://review.openstack.org/329764
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=fd1e846a60c0e73e641b22af2ed07b91b040c6a2
Submitter: Jenkins
Branch:    master

commit fd1e846a60c0e73e641b22af2ed07b91b040c6a2
Author: yuyafei <yu.yafei@xxxxxxxxxx>
Date:   Wed Jun 15 13:26:44 2016 +0800

    Fix argument order for assertEqual to (expected, observed)
    
    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.
    
    TrivialFix
    
    Change-Id: I07b78383ef38731140143c91ae3a902bea55eebb
    Closes-Bug: #1259292


** Changed in: glance-store
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1259292

Title:
  Some tests use assertEqual(observed, expected) , the argument order is
  wrong

Status in Barbican:
  In Progress
Status in Ceilometer:
  Invalid
Status in Cinder:
  Fix Released
Status in congress:
  Fix Released
Status in Designate:
  Fix Released
Status in Glance:
  Fix Released
Status in glance_store:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Magnum:
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Murano:
  Fix Released
Status in OpenStack Compute (nova):
  Won't Fix
Status in os-brick:
  In Progress
Status in python-ceilometerclient:
  Invalid
Status in python-cinderclient:
  Fix Released
Status in python-designateclient:
  Fix Committed
Status in python-glanceclient:
  In Progress
Status in python-mistralclient:
  Fix Released
Status in python-solumclient:
  Fix Released
Status in Python client library for Zaqar:
  Fix Released
Status in Sahara:
  Fix Released
Status in zaqar:
  Fix Released

Bug description:
  The test cases will produce a confusing error message if the tests
  ever fail, so this is worth fixing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1259292/+subscriptions