yahoo-eng-team team mailing list archive

[Andreas Scheuring <andreas.scheuring@xxxxxxxxxx>]

Public bug reported:

Seems like ML2 portbinding uses '' for indicating that the port is bound
to no host, while in times before ml2 "None" was used. This leads to
some strange checks in the code like [1]

This bug is to clean this up internally. The API still should take both
values, an empty string and none, but some code at the api layer should
normalize that to None. In addition the values in the ml2_portbinding
(and dvr portbinding) table need to be migrated.


Another related patch that introduced None values for ml2 portbiding as well was : https://review.openstack.org/#/c/181867/


[1]
https://review.openstack.org/#/c/320657/1/neutron/db/ipam_backend_mixin.py

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1595250

Title:
  ml2 Use None for portbinding.host instead of an empty String

Status in neutron:
  New

Bug description:
  Seems like ML2 portbinding uses '' for indicating that the port is
  bound to no host, while in times before ml2 "None" was used. This
  leads to some strange checks in the code like [1]

  This bug is to clean this up internally. The API still should take
  both values, an empty string and none, but some code at the api layer
  should normalize that to None. In addition the values in the
  ml2_portbinding (and dvr portbinding) table need to be migrated.

  
  Another related patch that introduced None values for ml2 portbiding as well was : https://review.openstack.org/#/c/181867/


  
  [1] https://review.openstack.org/#/c/320657/1/neutron/db/ipam_backend_mixin.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1595250/+subscriptions