yahoo-eng-team team mailing list archive

[Andrey Volkov <avolkov@xxxxxxxxxxxx>]

Public bug reported:

While I was looking at HostMapping object I found inconsistency in signature and call:
HostMapping._save_in_db(context, obj, updates) uses objects attributes id and host.
But then it is called from HostMapping.save second param is self.host which is not object
but just a string.

Existing test
(nova.tests.unit.objects.test_host_mapping.TestHostMappingObject.test_save)
doesn't catch this error because _save_in_db is mocked.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1595587

Title:
  Cannot save HostMapping object

Status in OpenStack Compute (nova):
  New

Bug description:
  While I was looking at HostMapping object I found inconsistency in signature and call:
  HostMapping._save_in_db(context, obj, updates) uses objects attributes id and host.
  But then it is called from HostMapping.save second param is self.host which is not object
  but just a string.

  Existing test
  (nova.tests.unit.objects.test_host_mapping.TestHostMappingObject.test_save)
  doesn't catch this error because _save_in_db is mocked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1595587/+subscriptions