yahoo-eng-team team mailing list archive

[Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>]

Public bug reported:

Description
===========
As oslo ObjectVersionChecker.test_hashes() does not provide a way to supply exta information to the fingerprint generation the current unit test does not detect if the SCHEMA of a versioned notification object has been changed without proper version bump. 

Compare the unit test test_versions with
test_notification_payload_version_depends_on_the_schema in
TestNotificationObjectVersions [1]

The former uses test_hashes without the extra_data_func while the later
uses the get_hashes() with extra_data_func.

[1]
https://github.com/openstack/nova/blob/master/nova/tests/unit/notifications/objects/test_notification.py#L267

Steps to reproduce
==================
Modify the SCHEMA of one of the notification object. 
Run the unit test
SCHEMA changes are not detected

Environment
===========
6a119fc72096fa65678112e151e4a7a00091ce26

** Affects: nova
     Importance: Undecided
     Assignee: Balazs Gibizer (balazs-gibizer)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Balazs Gibizer (balazs-gibizer)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1595575

Title:
  The hash of a notification object does not depend on its SCHEMA

Status in OpenStack Compute (nova):
  New

Bug description:
  Description
  ===========
  As oslo ObjectVersionChecker.test_hashes() does not provide a way to supply exta information to the fingerprint generation the current unit test does not detect if the SCHEMA of a versioned notification object has been changed without proper version bump. 

  Compare the unit test test_versions with
  test_notification_payload_version_depends_on_the_schema in
  TestNotificationObjectVersions [1]

  The former uses test_hashes without the extra_data_func while the
  later uses the get_hashes() with extra_data_func.

  [1]
  https://github.com/openstack/nova/blob/master/nova/tests/unit/notifications/objects/test_notification.py#L267

  Steps to reproduce
  ==================
  Modify the SCHEMA of one of the notification object. 
  Run the unit test
  SCHEMA changes are not detected

  Environment
  ===========
  6a119fc72096fa65678112e151e4a7a00091ce26

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1595575/+subscriptions