← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1604842] [NEW] Should hide expand while we haven't setTemplateUrl

 

Public bug reported:

Now if we haven't setSummaryTemplateUrl while register ResourceType, and
if we visit the  ResourceType angular table, it will always send a bunch
of get requests.

horizon/static/framework/widgets/table/hz-detail-row.directive.js
in the file, while haven't setSummaryTemplateUrl, the templateUrl and angular.isUndefined(templateUrl) will be false, it won't use the default templateUrl(basePath + 'table/hz-detail-row.html')

horizon/static/framework/widgets/table/hz-resource-table.controller.js
and expand value should be the same with the boolean of templateUrl(ctrl.resourceType.summaryTemplateUrl)

** Affects: horizon
     Importance: Undecided
     Assignee: Lawrance (jing)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1604842

Title:
  Should hide expand while we haven't setTemplateUrl

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  Now if we haven't setSummaryTemplateUrl while register ResourceType,
  and if we visit the  ResourceType angular table, it will always send a
  bunch of get requests.

  horizon/static/framework/widgets/table/hz-detail-row.directive.js
  in the file, while haven't setSummaryTemplateUrl, the templateUrl and angular.isUndefined(templateUrl) will be false, it won't use the default templateUrl(basePath + 'table/hz-detail-row.html')

  horizon/static/framework/widgets/table/hz-resource-table.controller.js
  and expand value should be the same with the boolean of templateUrl(ctrl.resourceType.summaryTemplateUrl)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1604842/+subscriptions


Follow ups