yahoo-eng-team team mailing list archive

[OpenStack Infra <1604842@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/344819
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0eb0bd2cb0d8aa13db59d4a1879901470daa5d56
Submitter: Jenkins
Branch:    master

commit 0eb0bd2cb0d8aa13db59d4a1879901470daa5d56
Author: jing.liuqing <jing.liuqing@xxxxxxxxxxx>
Date:   Wed Jul 20 21:01:03 2016 +0800

    [TrivialFix] Hide expand in angular table if we haven't setSummaryTemplateUrl
    
    Closes-Bug: #1604842
    
    Change-Id: I5f2aa263834c8e45025e0a148ee54aa730dfef03


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1604842

Title:
  Should hide expand while we haven't setTemplateUrl

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Now if we haven't setSummaryTemplateUrl while register ResourceType,
  and if we visit the  ResourceType angular table, it will always send a
  bunch of get requests.

  horizon/static/framework/widgets/table/hz-detail-row.directive.js
  in the file, while haven't setSummaryTemplateUrl, the templateUrl and angular.isUndefined(templateUrl) will be false, it won't use the default templateUrl(basePath + 'table/hz-detail-row.html')

  horizon/static/framework/widgets/table/hz-resource-table.controller.js
  and expand value should be the same with the boolean of templateUrl(ctrl.resourceType.summaryTemplateUrl)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1604842/+subscriptions