yahoo-eng-team team mailing list archive

[Lance Bragstad <lbragstad@xxxxxxxxx>]

I think this can be closed now since a bunch of fixes landed to make
fernet the default [0]. The TestFernetTokenProvider class has been
refactored in master and no longer exists. It has been replaced with
Fernet test classes that inherit tests from general test classes.


[0] https://review.openstack.org/#/q/status:merged+project:openstack/keystone+branch:master+topic:make-fernet-default

** Changed in: keystone
       Status: Triaged => Won't Fix

** Changed in: keystone
       Status: Won't Fix => Fix Committed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1433331

Title:
  Collapse Fernet specific tests into test_v3_auth.py TestAuth

Status in OpenStack Identity (keystone):
  Fix Committed

Bug description:
  When the Fernet token implementation landed, it was introduced with
  it's own testing layer [1]. These tests were designed to model the
  behavior specific to Fernet tokens. Fernet tokens should have the same
  V3 behavior as the rest of the token providers available in Keystone,
  which has been worked towards [2]. If the behavior is the same, then
  we should use the same tests with each provider. The
  TestFernetTokenProvider test cases should be analyzed and ported to
  TestAuth if not already there. Then we can leverage the work across
  all providers without having a bunch of tests that describe the same
  behavior for different providers.

  [1] https://github.com/openstack/keystone/blob/3910931b464c143b3be38c39e70038498860a8bd/keystone/tests/unit/test_v3_auth.py#L4053
  [2] https://review.openstack.org/#/c/164348/

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1433331/+subscriptions