yahoo-eng-team team mailing list archive

[Lance Bragstad <lbragstad@xxxxxxxxx>]

Public bug reported:

When the Fernet token implementation landed, it was introduced with it's
own testing layer [1]. These tests were designed to model the behavior
specific to Fernet tokens. Fernet tokens should have the same V3
behavior as the rest of the token providers available in Keystone, which
has been worked towards [2]. If the behavior is the same, then we should
use the same tests with each provider. The TestFernetTokenProvider test
cases should be analyzed and ported to TestAuth if not already there.
Then we can leverage the work across all providers without having a
bunch of tests that describe the same behavior for different providers.

[1] https://github.com/openstack/keystone/blob/3910931b464c143b3be38c39e70038498860a8bd/keystone/tests/unit/test_v3_auth.py#L4053
[2] https://review.openstack.org/#/c/164348/

** Affects: keystone
     Importance: Low
         Status: New


** Tags: fernet low-hanging-fruit test-improvement

** Description changed:

  When the Fernet token implementation landed, it was introduced with it's
  own testing layer [1]. These tests were designed to model the behavior
  specific to Fernet tokens. Fernet tokens should have the same V3
  behavior as the rest of the token providers available in Keystone, which
  has been worked towards [2]. If the behavior is the same, then we should
  use the same tests with each provider. The TestFernetTokenProvider test
- cases should be analyzed and port to TestAuth if not already there. Then
- we can leverage the work across all providers without have a bunch of
- tests that describe the same behavior for different providers.
- 
+ cases should be analyzed and ported to TestAuth if not already there.
+ Then we can leverage the work across all providers without have a bunch
+ of tests that describe the same behavior for different providers.
  
  [1] https://github.com/openstack/keystone/blob/3910931b464c143b3be38c39e70038498860a8bd/keystone/tests/unit/test_v3_auth.py#L4053
  [2] https://review.openstack.org/#/c/164348/

** Description changed:

  When the Fernet token implementation landed, it was introduced with it's
  own testing layer [1]. These tests were designed to model the behavior
  specific to Fernet tokens. Fernet tokens should have the same V3
  behavior as the rest of the token providers available in Keystone, which
  has been worked towards [2]. If the behavior is the same, then we should
  use the same tests with each provider. The TestFernetTokenProvider test
  cases should be analyzed and ported to TestAuth if not already there.
- Then we can leverage the work across all providers without have a bunch
- of tests that describe the same behavior for different providers.
+ Then we can leverage the work across all providers without having a
+ bunch of tests that describe the same behavior for different providers.
  
  [1] https://github.com/openstack/keystone/blob/3910931b464c143b3be38c39e70038498860a8bd/keystone/tests/unit/test_v3_auth.py#L4053
  [2] https://review.openstack.org/#/c/164348/

** Tags added: fernet test-improvement

** Changed in: keystone
   Importance: Undecided => Low

** Tags added: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1433331

Title:
  Collapse Fernet specific tests into test_v3_auth.py TestAuth

Status in OpenStack Identity (Keystone):
  New

Bug description:
  When the Fernet token implementation landed, it was introduced with
  it's own testing layer [1]. These tests were designed to model the
  behavior specific to Fernet tokens. Fernet tokens should have the same
  V3 behavior as the rest of the token providers available in Keystone,
  which has been worked towards [2]. If the behavior is the same, then
  we should use the same tests with each provider. The
  TestFernetTokenProvider test cases should be analyzed and ported to
  TestAuth if not already there. Then we can leverage the work across
  all providers without having a bunch of tests that describe the same
  behavior for different providers.

  [1] https://github.com/openstack/keystone/blob/3910931b464c143b3be38c39e70038498860a8bd/keystone/tests/unit/test_v3_auth.py#L4053
  [2] https://review.openstack.org/#/c/164348/

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1433331/+subscriptions