yahoo-eng-team team mailing list archive

[Miguel Angel Ajo <majopela@xxxxxxxxxx>]

Public bug reported:


The automatic call wrapper calls:
https://github.com/openstack/neutron/blob/17d85e4748f05b9785686f1164b6a4fe2963b8eb/neutron/extensions/qos.py#L273


with: (context, rule_obj, ....   to rule related methods.

While the abstractmethods are defined with: (context, ...., rule_obj).

https://github.com/openstack/neutron/blob/17d85e4748f05b9785686f1164b6a4fe2963b8eb/neutron/extensions/qos.py#L314

And btw, those are not rule_obj (objects) but rule_cls (classes).

** Affects: neutron
     Importance: Wishlist
     Assignee: Miguel Angel Ajo (mangelajo)
         Status: Triaged


** Tags: qos

** Changed in: neutron
       Status: New => Confirmed

** Changed in: neutron
       Status: Confirmed => Triaged

** Changed in: neutron
     Assignee: (unassigned) => Miguel Angel Ajo (mangelajo)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1608921

Title:
  The signature of the QoSPluginBase methods is wrong

Status in neutron:
  Triaged

Bug description:
  
  The automatic call wrapper calls:
  https://github.com/openstack/neutron/blob/17d85e4748f05b9785686f1164b6a4fe2963b8eb/neutron/extensions/qos.py#L273

  
  with: (context, rule_obj, ....   to rule related methods.

  While the abstractmethods are defined with: (context, ...., rule_obj).

  https://github.com/openstack/neutron/blob/17d85e4748f05b9785686f1164b6a4fe2963b8eb/neutron/extensions/qos.py#L314

  And btw, those are not rule_obj (objects) but rule_cls (classes).

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1608921/+subscriptions