yahoo-eng-team team mailing list archive

[OpenStack Infra <1608921@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/349965
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=795f5f1c872c170fb5f7391b2c280b73417aa2bf
Submitter: Jenkins
Branch:    master

commit 795f5f1c872c170fb5f7391b2c280b73417aa2bf
Author: Miguel Angel Ajo <mangelajo@xxxxxxxxxx>
Date:   Tue Aug 2 14:19:53 2016 +0200

    Fix the QoSPluginBase methods signature.
    
    rule_obj has been substituted for rule_cls which is more precise,
    and the abstract method signature has been fixed to be correct.
    
    Change-Id: I1dd25a346d13da80af4a1ca81f67563a8f9de94d
    Closes-bug: #1608921


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1608921

Title:
  The signature of the QoSPluginBase methods is wrong

Status in neutron:
  Fix Released

Bug description:
  
  The automatic call wrapper calls:
  https://github.com/openstack/neutron/blob/17d85e4748f05b9785686f1164b6a4fe2963b8eb/neutron/extensions/qos.py#L273

  
  with: (context, rule_obj, ....   to rule related methods.

  While the abstractmethods are defined with: (context, ...., rule_obj).

  https://github.com/openstack/neutron/blob/17d85e4748f05b9785686f1164b6a4fe2963b8eb/neutron/extensions/qos.py#L314

  And btw, those are not rule_obj (objects) but rule_cls (classes).

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1608921/+subscriptions