yahoo-eng-team team mailing list archive

[OpenStack Infra <1611834@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/352216
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=93a2e8911d16f17ce4a9d8b4e93f107a1750843e
Submitter: Jenkins
Branch:    master

commit 93a2e8911d16f17ce4a9d8b4e93f107a1750843e
Author: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxx>
Date:   Mon Aug 8 13:53:08 2016 +0900

    Fix db migration after project_id changes
    
    The previous coding didn't work for backends with transactional DDLs,
    like postgresql.  Also, the try-except doesn't seem to work as intended
    even with mysql in some cases.
    
    Co-Authored-By: Ann Taraday <akamyshnikova@xxxxxxxxxxxx>
    Closes-Bug: #1610815
    Closes-Bug: #1611834
    Change-Id: I8f5880b8f6149b8c8017808cb8930f20eae36cd6


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1611834

Title:
  [neutron-fwaas] "Unknown column 'r.tenant_id' in 'where clause'"

Status in neutron:
  Fix Released

Bug description:
  A neutron database upgrade using the master branches results in a
  traceback that includes "Unknown column 'r.tenant_id' in 'where
  clause'".

  The upgrade command is:

  neutron-db-manage --config-file /etc/neutron/neutron.conf --config-
  file /etc/neutron/plugins/ml2/ml2_conf.ini upgrade head

  It seems that it may be related to the following change in neutron-
  fwaas:

  commit c3e491cae388713bb175d803de6a216a8816b816
  Author: Henry Gessau <gessau@xxxxxxxxx>
  Date:   Thu Jul 14 13:59:31 2016 -0400

      Rename DB columns: tenant -> project
      
      All occurences of ``tenant_id`` across the neutron database are
      being renamed to ``project_id``.
      
      This neutron-fwaas change accompanies the neutron change:
      I87a8ef342ccea004731ba0192b23a8e79bc382dc
      
      Partially-Implements: blueprint keystone-v3
      
      Change-Id: I984502745629280c033e52f0f1c06fc268fa0255

  Meanwhile,
  neutron_fwaas/db/migration/alembic_migrations/versions/540142f314f4_fwaas_router_insertion.py
  still has tenant_id in the SQL_STATEMENT:

  SQL_STATEMENT = (
      "insert into firewall_router_associations "
      "select "
      "f.id as fw_id, r.id as router_id "
      "from firewalls f, routers r "
      "where "
      "f.tenant_id=r.%s"
  )

  Attached is a full traceback.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1611834/+subscriptions