← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1624730] [NEW] i18n: unnecessary translate tag in hz-detail-row.html

 

Public bug reported:

In horizon/static/framework/widgets/table/hz-detail-row.html, <dt> and
<dd> tags are marked as 'translate', but they contains no translatable
strings. 'translate' is unnecessary.

By removing them, it avoid unnecessary confusion for translators.
Translators usually do not understand actual codes and they wonder how
they can do for them.

 <div class="row">
   <span class="rsp-alt-p2">
     <dl class="col-sm-2" ng-repeat="column in config.columns">
       <dt translate>{$ column.title $}</dt>
       <dd translate><hz-cell table="table" column="column" item="item"></hz-cell></dd>
     </dl>
   </span>
 </div>

** Affects: horizon
     Importance: Low
     Assignee: Akihiro Motoki (amotoki)
         Status: In Progress


** Tags: i18n

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1624730

Title:
  i18n: unnecessary translate tag in hz-detail-row.html

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  In horizon/static/framework/widgets/table/hz-detail-row.html, <dt> and
  <dd> tags are marked as 'translate', but they contains no translatable
  strings. 'translate' is unnecessary.

  By removing them, it avoid unnecessary confusion for translators.
  Translators usually do not understand actual codes and they wonder how
  they can do for them.

   <div class="row">
     <span class="rsp-alt-p2">
       <dl class="col-sm-2" ng-repeat="column in config.columns">
         <dt translate>{$ column.title $}</dt>
         <dd translate><hz-cell table="table" column="column" item="item"></hz-cell></dd>
       </dl>
     </span>
   </div>

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1624730/+subscriptions


Follow ups