yahoo-eng-team team mailing list archive

[OpenStack Infra <1624730@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/371980
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a2de34163a351a56680b086303fa23201db2bbb2
Submitter: Jenkins
Branch:    master

commit a2de34163a351a56680b086303fa23201db2bbb2
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Sat Sep 17 20:44:41 2016 +0000

    Remove unnecessary translate mark
    
    <dt> and <dd> tags in hz-detail-row.html contains no translatable strings.
    They are unnecessary.
    
    Change-Id: Ic0a687fb3266b02de7dab3e4079c391a45cf95d7
    Closes-Bug: #1624730


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1624730

Title:
  i18n: unnecessary translate tag in hz-detail-row.html

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In horizon/static/framework/widgets/table/hz-detail-row.html, <dt> and
  <dd> tags are marked as 'translate', but they contains no translatable
  strings. 'translate' is unnecessary.

  By removing them, it avoid unnecessary confusion for translators.
  Translators usually do not understand actual codes and they wonder how
  they can do for them.

   <div class="row">
     <span class="rsp-alt-p2">
       <dl class="col-sm-2" ng-repeat="column in config.columns">
         <dt translate>{$ column.title $}</dt>
         <dd translate><hz-cell table="table" column="column" item="item"></hz-cell></dd>
       </dl>
     </span>
   </div>

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1624730/+subscriptions