yahoo-eng-team team mailing list archive

[Akihiro Motoki <1624757@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

String concatenation makes translation difficult in some cases.
There are some string concatenations in JS code.

openstack_dashboard/contrib/developer/static/dashboard/developer
/resource-browser/resource-browser-item.controller.js

  toastService.add('error', gettext("resource load failed: " + reason));

openstack_dashboard/dashboards/project/static/dashboard/project/workflow
/launch-instance/keypair/create-keypair.controller.js

  var errorMessage = gettext('Unable to generate') + ' "' + ctrl.keypair + '". ' +
      gettext('Please try again.');

openstack_dashboard/dashboards/project/static/dashboard/project/workflow
/launch-instance/keypair/keypair.controller.js

  toastService.add('success', gettext('Created keypair: ' +
newKeypair.name));

** Affects: horizon
     Importance: Low
     Assignee: Akihiro Motoki (amotoki)
         Status: In Progress


** Tags: i18n newton-rc-potential

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1624757

Title:
  i18n: string concatenations in JavaScript code

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  String concatenation makes translation difficult in some cases.
  There are some string concatenations in JS code.

  openstack_dashboard/contrib/developer/static/dashboard/developer
  /resource-browser/resource-browser-item.controller.js

    toastService.add('error', gettext("resource load failed: " +
  reason));

  openstack_dashboard/dashboards/project/static/dashboard/project/workflow
  /launch-instance/keypair/create-keypair.controller.js

    var errorMessage = gettext('Unable to generate') + ' "' + ctrl.keypair + '". ' +
        gettext('Please try again.');

  openstack_dashboard/dashboards/project/static/dashboard/project/workflow
  /launch-instance/keypair/keypair.controller.js

    toastService.add('success', gettext('Created keypair: ' +
  newKeypair.name));

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1624757/+subscriptions