yahoo-eng-team team mailing list archive

[OpenStack Infra <1624757@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/371987
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=64362120733682859e734b2f869b267226100760
Submitter: Jenkins
Branch:    master

commit 64362120733682859e734b2f869b267226100760
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Sat Sep 17 21:41:16 2016 +0000

    i18n: Avoid string concatenations to make translation life happier
    
    Change-Id: Iea0cef814f212662dc4403f62a2c6bea02ab1390
    Closes-Bug: #1624757


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1624757

Title:
  i18n: string concatenations in JavaScript code

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  String concatenation makes translation difficult in some cases.
  There are some string concatenations in JS code.

  openstack_dashboard/contrib/developer/static/dashboard/developer
  /resource-browser/resource-browser-item.controller.js

    toastService.add('error', gettext("resource load failed: " +
  reason));

  openstack_dashboard/dashboards/project/static/dashboard/project/workflow
  /launch-instance/keypair/create-keypair.controller.js

    var errorMessage = gettext('Unable to generate') + ' "' + ctrl.keypair + '". ' +
        gettext('Please try again.');

  openstack_dashboard/dashboards/project/static/dashboard/project/workflow
  /launch-instance/keypair/keypair.controller.js

    toastService.add('success', gettext('Created keypair: ' +
  newKeypair.name));

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1624757/+subscriptions