← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1625604] Re: The timeout is not honored in NeutronOVSDBTransaction

 

Reviewed:  https://review.openstack.org/373231
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a01ca102500cb4705c6c4d8e10180931aa7d5056
Submitter: Jenkins
Branch:    master

commit a01ca102500cb4705c6c4d8e10180931aa7d5056
Author: Hong Hui Xiao <honghui_xiao@xxxxxxxx>
Date:   Tue Sep 20 20:15:21 2016 +0800

    Fix wrong use of six.moves.queue.get()
    
    timeout is not the first positional argument.
    
    Change-Id: Icd745514adc14730b9179fa7a6dd5c115f5e87a5
    Closes-Bug: #1625604


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1625604

Title:
  The timeout is not honored  in NeutronOVSDBTransaction

Status in neutron:
  Fix Released

Bug description:
  According to [1], the usage of [2] is not appropriate. If timeout > 0,
  the commit will wait forever.

  
  [1] https://docs.python.org/2/library/queue.html#module-Queue
  [2] https://github.com/openstack/neutron/blob/be29217d82cc633bda1a66c2e50612de1e3f7e15/neutron/agent/ovsdb/impl_idl.py#L67

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1625604/+subscriptions


References