← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1623573] Re: placement API functional test fixtures do not do appropriate stdout and stderr handling

 

Reviewed:  https://review.openstack.org/374256
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=687984bcb4a259dcc8e88e9d9b902b103bb396a1
Submitter: Jenkins
Branch:    master

commit 687984bcb4a259dcc8e88e9d9b902b103bb396a1
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Wed Sep 21 15:41:58 2016 +0000

    [placement] Manage log and other output in gabbi fixure
    
    Recent changes to the placement API added more verbose logging and
    output across both stdout and stderr. In test runs this resulted in
    a combination of far too much output as well as output that was
    impossible to read because it was interleaved.
    
    This change uses fixtures from nova.tests.fixtures to capture
    stray output streams and logs.
    
    It also adds a specific logger for the ERROR level that overrides
    the fixture log handling to send that level to the default stderr.
    This is required in order to effectively see error messages on both
    side of the wsgi-intercept used when running gabbi. Without this,
    the errors are swallowed and test development and debugging,
    especially locally for TDD, is hamstrung.
    
    Closes-Bug: #1623573
    Change-Id: I300456b0261dfc0ae46c799e5a03cbeab25106c2


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1623573

Title:
  placement API functional test fixtures do not do appropriate stdout
  and stderr handling

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In a multi-process environment the logging that is done in the
  placement API when it is running under functional tests with gabbi
  interleaves, resulting in illegible output in test runs. Makes it
  pretty hard to do anything when a failure happens.

  There are fixtures that other nova tests use that ought to be reusable
  here.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1623573/+subscriptions


References