← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1624751] Re: i18n: duplicate 'translate' marking in theme-preview.html

 

Reviewed:  https://review.openstack.org/371986
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4340fc25fe618e849771e7cbca54b8b3383df3e5
Submitter: Jenkins
Branch:    master

commit 4340fc25fe618e849771e7cbca54b8b3383df3e5
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Sat Sep 17 21:33:21 2016 +0000

    Remove duplicated inappropriate 'translate' tag
    
    Change-Id: Id07287e20760116285cb5fda86aac272b8d06e35
    Closes-Bug: #1624751


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1624751

Title:
  i18n: duplicate 'translate' marking in theme-preview.html

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  There are duplicated and nested 'translated' mark in theme-
  preview.html.

                 <div class="col-lg-10">
                   <div class="themable-radio">
                     <input type="radio" name="optionsThemableRadios" id="optionsRadios3" value="option1" checked="">
                     <label translate for="optionsRadios3">
                       <span>{$ 'Themable Option 1' | translate $}</span>
                     </label>
                   </div>
                   <div class="themable-radio">
                     <input type="radio" name="optionsThemableRadios" id="optionsRadios4" value="option2">
                     <label translate for="optionsRadios4">
                      <span>{$ 'Themable Option 2' | translate $}</span>
                     </label>
                   </div>

  As a result, we have the following entries in PO files.

  <span>{$ 'Themable Option 1' | translate $}</span>
  <span>{$ 'Themable Option 2' | translate $}</span>

  Themable Option 1/2 should be extracted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1624751/+subscriptions


References