yahoo-eng-team team mailing list archive

[OpenStack Infra <1596829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/334844
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4eb89c206e68a7172ebad897ad24769036c7bdd6
Submitter: Jenkins
Branch:    master

commit 4eb89c206e68a7172ebad897ad24769036c7bdd6
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Tue Jun 28 16:42:31 2016 +0900

    Add a hacking rule for string interpolation at logging
    
    String interpolation should be delayed to be handled
    by the logging code, rather than being done
    at the point of the logging call.
    So add the following hacking rule for it.
    
    - [N354] String interpolation should be delayed at logging calls.
    
    See the oslo i18n guideline.
    
    * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
    
    Change-Id: Ief6d3ee3539c0857098fffdb7acfeec3e0fed6eb
    Closes-Bug: #1596829


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596829

Title:
  String interpolation should be delayed at logging calls

Status in Ceilometer:
  New
Status in congress:
  Fix Released
Status in Glance:
  In Progress
Status in glance_store:
  In Progress
Status in heat:
  New
Status in Ironic:
  Fix Released
Status in masakari:
  Fix Released
Status in networking-vsphere:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in os-brick:
  Fix Released
Status in os-vif:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-neutronclient:
  Fix Released

Bug description:
  String interpolation should be delayed to be handled by the logging
  code, rather than being done at the point of the logging call.

  Wrong: LOG.debug('Example: %s' % 'bad')
  Right: LOG.debug('Example: %s', 'good')

  See the following guideline.

  * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
  #adding-variables-to-log-messages

  The rule for it should be added to hacking checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions