yahoo-eng-team team mailing list archive

[OpenStack Infra <1604073@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/343799
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=abeb5c4de0f50bba23cbc9750a095b9423dd33d5
Submitter: Jenkins
Branch:    master

commit abeb5c4de0f50bba23cbc9750a095b9423dd33d5
Author: Pablo Iranzo Gómez <Pablo.Iranzo@xxxxxxxxxx>
Date:   Sat Sep 24 22:08:19 2016 +0200

    Enhance valid_values to use __contains__
    
    Actually valid_values doesn't cover many of the use cases or validates
    that the value and valid_values provided can be used with 'in' call.
    
    his patch tries to improve this situation to ensure that both are valid
    for being checked or fail otherwise plus validating that valid_values
    contains the value provided.
    
    Closes-Bug: 1604073
    Change-Id: I47a6f7d58d6cbeb8fd245620d187c4c565497290


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1604073

Title:
  neutron-lib's validate_values function is incomplete and might fail
  for some checks

Status in neutron:
  Fix Released

Bug description:
  From comments on https://review.openstack.org/#/c/337237/, we tried to
  ensure some validations are working properly, but when we rely on
  validate_values function, it should also handle the case that
  'valid_values' might not provide a  "__contains__" method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1604073/+subscriptions