← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1621698] Re: AFTER_DELETE event for SECURITY_GROUP_RULE should contain sg_id

 

Reviewed:  https://review.openstack.org/367728
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3e25ee3e28e1832b8eb0474db1e980b75f377df1
Submitter: Jenkins
Branch:    master

commit 3e25ee3e28e1832b8eb0474db1e980b75f377df1
Author: Hong Hui Xiao <honghui_xiao@xxxxxxxx>
Date:   Fri Sep 9 10:27:47 2016 +0800

    Add sg_id in the AFTER_DELETE event of sg_rule delete
    
    In the AFTER_DELETE of sg_rule delete, the sg_rule is actually deleted.
    This makes it impossible/hard to know which sg is affected.
    
    This patch add the sg_id in the event. And this patch will be used in [1].
    
    [1] https://review.openstack.org/#/c/367718
    
    Change-Id: Ibdef6a703913b74504e402d225b1a0dffadb7aff
    Closes-Bug: #1621698


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1621698

Title:
  AFTER_DELETE event for SECURITY_GROUP_RULE should contain sg_id

Status in neutron:
  Fix Released

Bug description:
  In the notification of AFTER_DELETE event for SECURITY_GROUP_RULE, the
  security group rule is actually deleted from DB. There is no way for
  subscriber to know the latest information of related security group.

  To be specific, dragonflow will maintain the security group version,
  and we are using revision_number in dragonflow now. The sg_rule_delete
  will bump the sg revision, which will only happen after the db
  transaction. dragonflow stores security group rule as part of security
  group. So, in the AFTER_DELETE event of SECURITY_GROUP_RULE, we don't
  know which security group is updated, if neutron don't pass the
  security group id.

  We can query all security group and iterate their security group
  rules. But that is inefficient and it will be nice if neutron just
  pass the related security group id.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1621698/+subscriptions


References