yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

This code is passing a string for expected_attrs when getting all
instances:

https://github.com/openstack/nova/blob/4e747092bcb015303efc2ab13da98ef5ce575ec8/nova/api/openstack/compute/server_external_events.py#L72

That's used to join the migration_context from the DB, but it's not
doing that as expected_attr should be a list:

https://github.com/openstack/nova/blob/4e747092bcb015303efc2ab13da98ef5ce575ec8/nova/objects/instance.py#L73

So we aren't getting the optimization in the API.

That was added in https://review.openstack.org/#/c/371048/ which was
also backported to stable/newton.

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged

** Affects: nova/newton
     Importance: Undecided
         Status: New


** Tags: api

** Also affects: nova/newton
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1645479

Title:
  ServerExternalEventsController doesn't properly pre-load
  migration_context

Status in OpenStack Compute (nova):
  Triaged
Status in OpenStack Compute (nova) newton series:
  New

Bug description:
  This code is passing a string for expected_attrs when getting all
  instances:

  https://github.com/openstack/nova/blob/4e747092bcb015303efc2ab13da98ef5ce575ec8/nova/api/openstack/compute/server_external_events.py#L72

  That's used to join the migration_context from the DB, but it's not
  doing that as expected_attr should be a list:

  https://github.com/openstack/nova/blob/4e747092bcb015303efc2ab13da98ef5ce575ec8/nova/objects/instance.py#L73

  So we aren't getting the optimization in the API.

  That was added in https://review.openstack.org/#/c/371048/ which was
  also backported to stable/newton.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1645479/+subscriptions