yahoo-eng-team team mailing list archive

[OpenStack Infra <1645479@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/403917
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cbcff11b6a206a58093017fb9471d818d484ca34
Submitter: Jenkins
Branch:    master

commit cbcff11b6a206a58093017fb9471d818d484ca34
Author: Matt Riedemann <mriedem@xxxxxxxxxx>
Date:   Mon Nov 28 16:45:58 2016 -0500

    Fix expected_attrs kwarg in server_external_events
    
    The Instance.get_by_uuid method takes an expected_attrs
    kwarg which needs to be a list or tuple, not just any old
    iterable like a string. Because of how the underlying
    Instance object code massages this value, it's not a hard
    failure but does mean you don't join the columns you expect
    when getting the instance.
    
    This makes it a list and makes sure the stub in the unit
    tests is checking for valid values.
    
    Change-Id: I3ad85f9062b5cb19962d9e6a7af52440166def45
    Closes-Bug: #1645479


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1645479

Title:
  ServerExternalEventsController doesn't properly pre-load
  migration_context

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) newton series:
  New

Bug description:
  This code is passing a string for expected_attrs when getting all
  instances:

  https://github.com/openstack/nova/blob/4e747092bcb015303efc2ab13da98ef5ce575ec8/nova/api/openstack/compute/server_external_events.py#L72

  That's used to join the migration_context from the DB, but it's not
  doing that as expected_attr should be a list:

  https://github.com/openstack/nova/blob/4e747092bcb015303efc2ab13da98ef5ce575ec8/nova/objects/instance.py#L73

  So we aren't getting the optimization in the API.

  That was added in https://review.openstack.org/#/c/371048/ which was
  also backported to stable/newton.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1645479/+subscriptions