yahoo-eng-team team mailing list archive

[OpenStack Infra <1384462@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/199997
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=89d0304d19e5789bc5b42b30e39e1e71a7f2bdfe
Submitter: Jenkins
Branch:    master

commit 89d0304d19e5789bc5b42b30e39e1e71a7f2bdfe
Author: Albert Tu <albert.t@xxxxxxxxxxxxxx>
Date:   Thu Oct 20 15:31:23 2016 +0800

    Add i18n support to Quota.humanizeNumbers
    
    Show localized number format via ECMAScript i18n API.
    
    Closes-Bug: #1384462
    
    Change-Id: Ia8ca3c93c157bfb791f711529d60ce610b3686fe


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1384462

Title:
  angular humanizeNumbers utility is not internationalized

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  While browsing code I ran across 
  horizon/static/horizon/js/angular/services/horizon.utils.js#L25

   humanizeNumbers: function (number) {
  return number.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
  },

  which is not a proper way to group numbers in all locales.

  http://en.wikipedia.org/wiki/Decimal_mark#Other_numeral_systems ,
  Examples of use shows various internationalized examples.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1384462/+subscriptions