← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1384462] [NEW] our angular humanizeNumbers utility is not internationalized

 

Public bug reported:

While browsing code I ran across 
horizon/static/horizon/js/angular/services/horizon.utils.js#L25

 humanizeNumbers: function (number) {
return number.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
},

which is not a proper way to group numbers in all locales.

http://en.wikipedia.org/wiki/Decimal_mark#Other_numeral_systems ,
Examples of use shows various internationalized examples.

** Affects: horizon
     Importance: Undecided
         Status: New


** Tags: i18n

** Tags added: i18n

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1384462

Title:
  our angular humanizeNumbers utility is not internationalized

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  While browsing code I ran across 
  horizon/static/horizon/js/angular/services/horizon.utils.js#L25

   humanizeNumbers: function (number) {
  return number.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
  },

  which is not a proper way to group numbers in all locales.

  http://en.wikipedia.org/wiki/Decimal_mark#Other_numeral_systems ,
  Examples of use shows various internationalized examples.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1384462/+subscriptions


Follow ups

References