yahoo-eng-team team mailing list archive

[OpenStack Infra <1647370@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/405575
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=25bc5a663963dea814278312a6320504da837d43
Submitter: Jenkins
Branch:    master

commit 25bc5a663963dea814278312a6320504da837d43
Author: Ludovic Beliveau <ludovic.beliveau@xxxxxxxxxxxxx>
Date:   Thu Dec 1 13:15:19 2016 -0500

    Resource tracker doesn't free resources on confirm resize
    
    If the audit hasn’t been triggered and confirm resize is executed, the
    resources aren't dropped right away because the itype stored in the
    self.tracked_migrations corresponds to the new flavor.  However, the
    resource usage would get recalculated correctly by the next periodic
    resource audit.
    
    If the audit got executed, it corresponds to the old flavor, and resources
    get dropped properly.
    
    This patch removes part of the condition in drop_move_claim() which was
    trying to validate that the instance type (itype) stored in the
    tracked_migration was corresponding instance type being passed in the
    method.  Looking at the code where drop_move_claim() is being called shows
    that we can safely remove this check since it is known (based on the prefix)
    which resources needs to be dropped.
    
    Also, unit test changes from b816e3 were moved to a separate test.  It
    introduced a hacky way to force the migration dest_compute and makes it hard
    to keep _test_finish_revert_resize() generic and have the resources correctly
    tracked.
    
    Closes-Bug: #1647370
    Change-Id: Ic02b56be5684d9206ece4c20f5194802dfe12e25


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1647370

Title:
  Resource tracker doesn't free resources on confirm resize

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description
  ===========

  If the audit hasn’t been triggered and confirm resize is executed, the resources aren't dropped because the itype stored in the self.tracked_migrations correspond to new flavor.
      
  But if the audit got executed, it correspond to the old flavor, and resources gets dropped properly.

  Steps to reproduce
  ==================

  1) Resize a guest
  2) Confirm the resize before the periodic audit gets triggered

  Expected result
  ===============

  The guest's resources corresponding to the initial flavor should had
  been freed.

  Actual result
  =============

  The guest's resources corresponding to the initial flavor aren't
  freed.

  Environment
  ===========

  commit e83a3572344f9be39930ea9ead83a1f9b94ac7fe
  Author: Timofey Durakov <tdurakov@xxxxxxxxxxxx>
  Date:   Thu Dec 1 11:58:18 2016 +0300

      Fix for live-migration job
      
      Commit 9293ac0 to devstack-plugin-ceph altered
      CEPH_LOOPBACK_DISK_SIZE_DEFAULT variable initialization
      This fix added source for setting this variable in correct way.
      
      Closes-Bug: #1646418
      
      Change-Id: I84c3b78c53cfa283e9bcb7cf4b70ec6c95044e9c

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1647370/+subscriptions