yahoo-eng-team team mailing list archive

[Lance Bragstad <lbragstad@xxxxxxxxx>]

Public bug reported:

If you happen to take a look through keystone exception module [0].
You'll notice that some of the exceptions use proper punctuation, while
other do not. David Stanek mentioned this in a review [1], and we
thought it was appropriate to track it as a low-hanging-fruit bug.

We should decide what that convention should be for keystone, then apply
it to all of our exceptions consistently.

[0] https://github.com/openstack/keystone/blob/f8ee249bf08cefd8468aa15c589dab48bd5c4cd8/keystone/exception.py#L105-L118
[1] https://review.openstack.org/#/c/415895/8/keystone/exception.py

** Affects: keystone
     Importance: Undecided
         Status: New


** Tags: low-hanging-fruit

** Description changed:

  If you happen to take a look through keystone exception module [0].
- You'll notice that some of the exception use proper punctuation, while
+ You'll notice that some of the exceptions use proper punctuation, while
  other do not. David Stanek mentioned this in a review [1], and we
  thought it was appropriate to track it as a low-hanging-fruit bug.
  
  We should decide what that convention should be for keystone, then apply
  it to all of our exceptions consistently.
  
  [0] https://github.com/openstack/keystone/blob/f8ee249bf08cefd8468aa15c589dab48bd5c4cd8/keystone/exception.py#L105-L118
  [1] https://review.openstack.org/#/c/415895/8/keystone/exception.py

** Tags added: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1656026

Title:
  Exception don't follow a punctuation convention

Status in OpenStack Identity (keystone):
  New

Bug description:
  If you happen to take a look through keystone exception module [0].
  You'll notice that some of the exceptions use proper punctuation,
  while other do not. David Stanek mentioned this in a review [1], and
  we thought it was appropriate to track it as a low-hanging-fruit bug.

  We should decide what that convention should be for keystone, then
  apply it to all of our exceptions consistently.

  [0] https://github.com/openstack/keystone/blob/f8ee249bf08cefd8468aa15c589dab48bd5c4cd8/keystone/exception.py#L105-L118
  [1] https://review.openstack.org/#/c/415895/8/keystone/exception.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1656026/+subscriptions