← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1653986] Re: Many views are using identical table templates

 

Reviewed:  https://review.openstack.org/416694
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=560f23a1c9bb29651be56cabf77236e3024d14c2
Submitter: Jenkins
Branch:    master

commit 560f23a1c9bb29651be56cabf77236e3024d14c2
Author: Rob Cresswell <robert.cresswell@xxxxxxxxxxx>
Date:   Wed Jan 4 16:32:33 2017 +0000

    Add default common template to python table views
    
    Many of the Python table views are using identical (or nearly identical)
    table templates. This patch adds a common template and makes it the
    default for a DataTableView, which allows us to remove many similar
    templates and redundant lines of code.
    
    Change-Id: I1e4e15e695ee1f21f4d44f141a854e30f1e567a1
    Closes-Bug: 1653986


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1653986

Title:
  Many views are using identical table templates

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Many of our table views are using:

  {% extends 'base.html' %}
  {% block title %}{{ page_title }}{% endblock %}
  {% block main %}{{ table.render }}{% endblock %}

  as a template. We should make a common template and remove these.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1653986/+subscriptions


References