yahoo-eng-team team mailing list archive

[OpenStack Infra <1654188@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/423732
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=645df690371bfe5f2f9c32247a054c4da421556b
Submitter: Jenkins
Branch:    master

commit 645df690371bfe5f2f9c32247a054c4da421556b
Author: liyingjun <yingjun.li@xxxxxxxxxxxxxxx>
Date:   Sun Jan 22 10:20:13 2017 +0800

    Add deleting log when config drive was imported to rbd
    
    There is a log when creating config drive, the config drive will be
    deleted when we are using rbd driver, it would be confused for
    administrators who are trying to find the deleted file because of
    no related log which indicates that it was deleted.
    
    Change-Id: Ide1daf552757f9a24a740cca9c5c8427cb470242
    Closes-bug: #1654188


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1654188

Title:
  nova compute log misleading config drvie's state

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  I noticed that instances' config drive would been tried to import into
  image backend and local disk.config file is to be deleted if image
  backend is RBD.

  All functions work as expected, what puzzled me once is that the nova-compute log claimed:
  [instance: b54f657b-268c-438a-ba48-a6ee9de0fd8d] Using config drive
  [instance: b54f657b-268c-438a-ba48-a6ee9de0fd8d] Creating config drive at /var/lib/nova/instances/b54f657b-268c-438a-ba48-a6ee9de0fd8d/disk.config

  but this file didn't exist actually.

  I figured out that it had been imported into RBD backend and deleted
  from local after I read related code. I'm worried this may confuse
  some cloud administrators who don't read source codes.

  Maybe it's better to print info log before the config drive is to be imported into image backend and deleted from local, just as the following:
  [instance: b54f657b-268c-438a-ba48-a6ee9de0fd8d] Using config drive
  [instance: b54f657b-268c-438a-ba48-a6ee9de0fd8d] Creating config drive at /var/lib/nova/instances/b54f657b-268c-438a-ba48-a6ee9de0fd8d/disk.config
  [instance: b54f657b-268c-438a-ba48-a6ee9de0fd8d] Importing config drive into image backend at 192.168.120.241:vms/b54f657b-268c-438a-ba48-a6ee9de0fd8d_disk.config
  [instance: b54f657b-268c-438a-ba48-a6ee9de0fd8d] Deleting local config drive /var/lib/nova/instances/b54f657b-268c-438a-ba48-a6ee9de0fd8d/disk.config

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1654188/+subscriptions