yahoo-eng-team team mailing list archive

[Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>]

Public bug reported:

There are some misuse of assertTrue in the following files.

* nova/tests/unit/scheduler/client/test_report.py
* nova/tests/unit/api/openstack/compute/test_hypervisors.py
* nova/tests/unit/objects/test_instance_device_metadata.py

https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/scheduler/client/test_report.py#L522
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L316
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L362
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L60
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L64

** Affects: nova
     Importance: Undecided
     Assignee: Takashi NATSUME (natsume-takashi)
         Status: New


** Tags: testing

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1664446

Title:
  Misuse of assertTrue in unit tests

Status in OpenStack Compute (nova):
  New

Bug description:
  There are some misuse of assertTrue in the following files.

  * nova/tests/unit/scheduler/client/test_report.py
  * nova/tests/unit/api/openstack/compute/test_hypervisors.py
  * nova/tests/unit/objects/test_instance_device_metadata.py

  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/scheduler/client/test_report.py#L522
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L316
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L362
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L60
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L64

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1664446/+subscriptions