yahoo-eng-team team mailing list archive

[OpenStack Infra <1664446@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/433454
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5b49f4dfd288b02fd2b361dcc29f4a83f1468d3a
Submitter: Jenkins
Branch:    master

commit 5b49f4dfd288b02fd2b361dcc29f4a83f1468d3a
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Tue Feb 14 14:23:46 2017 +0900

    Fix misuse of assertTrue
    
    Fix misuse of assertTrue in the following files.
    
    * nova/tests/unit/api/openstack/compute/test_hypervisors.py
    * nova/tests/unit/objects/test_instance_device_metadata.py
    * nova/tests/unit/scheduler/client/test_report.py
    
    Change-Id: I5dd869ddec53cf0b9d27d99cb01d780e361a5810
    Closes-Bug: #1664446


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1664446

Title:
  Misuse of assertTrue in unit tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  There are some misuse of assertTrue in the following files.

  * nova/tests/unit/scheduler/client/test_report.py
  * nova/tests/unit/api/openstack/compute/test_hypervisors.py
  * nova/tests/unit/objects/test_instance_device_metadata.py

  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/scheduler/client/test_report.py#L522
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L316
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L362
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L60
  https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L64

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1664446/+subscriptions