yahoo-eng-team team mailing list archive

[OpenStack Infra <1617140@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/364049
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eedac01a9c529868b5d9be1294d8ea0a955614e2
Submitter: Jenkins
Branch:    master

commit eedac01a9c529868b5d9be1294d8ea0a955614e2
Author: shlo <samlo@xxxxxxxxxxxxxxxx>
Date:   Thu Sep 1 11:27:49 2016 +0800

    fix workflow exception on host aggregate create form
    
    Under the circumstance that there are existing aggregates, this bug
    happens when create button is clicked without the required "name" field
    filled. Error toast shows instead of the expected error message on the
    create form.
    When the form posts without name filed filled, the name attribute in the
    clean data is None instead of an empty string, which causes
    AttributeError on the following string operation.
    
    1. patch an empty string as the fallback value for the 'name' variable
    2. corresponding unit test is attached
    
    Change-Id: I0bdf469d87aa06ab58b73e6ce41bdf63bb36a538
    Closes-Bug: #1617140


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1617140

Title:
  form exception on host aggregate create

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The expected error message about missing the required "name" field on the create-aggregate form is shown as expected only in the case that there were no existing aggregates in the system.
  Under the circumstance that there are existing aggregates, workflow exception raises when create button is clicked without the required "name" field filled.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1617140/+subscriptions