yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

And to be clear, you have custom image metadata properties that are not
part of the ImageMetaProps object? That's why they get filtered out of
the object.

Also, this is in the zvm virt driver right?

image_meta = self._image_api.get(context, image_meta.id)

And that's specifically because the zvm driver needs to get the full
image with your custom metadata properties because the ImageMetaProps
object filters them out because they aren't "registered" as properties
we (upstream nova) know about.

In that case, I'm going to close this. If you need to get the image
metadata properties into the ImageMetaProps object you'd have to propose
that upstream, but it might be hard to justify for an out of tree
driver.

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1647347

Title:
  image_meta code migration in finish_migraiton  from older release

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  we had some problem when migrate from older release from L to N (it's
  not kvm driver)

  
  we had this error in virt layer in finish_migration function when we use following code in virt layer's finish_migration

  image_meta = self._image_api.get(context, image_meta.id)

  2016-12-01 07:09:14.600 35918 ERROR nova.compute.manager [instance: c7c2adff-6e33-4b3f-b5e3-74327ea80416]     self.obj_load_attr(name)
  2016-12-01 07:09:14.600 35918 ERROR nova.compute.manager [instance: c7c2adff-6e33-4b3f-b5e3-74327ea80416]   File "/usr/lib/python2.7/site-packages/oslo_versionedobjects/base.py", line 627, in obj_load_attr
  2016-12-01 07:09:14.600 35918 ERROR nova.compute.manager [instance: c7c2adff-6e33-4b3f-b5e3-74327ea80416]     _("Cannot load '%s' in the base class") % attrname)
  2016-12-01 07:09:14.600 35918 ERROR nova.compute.manager [instance: c7c2adff-6e33-4b3f-b5e3-74327ea80416] NotImplementedError: Cannot load 'id' in the base class
  2016-12-01 07:09:14.600 35918 ERROR nova.compute.manager [instance: c7c2adff-6e33-4b3f-b5e3-74327ea80416]

  so the problem is seems we didn't have image_meta.id set if it's an
  old instance because old instance image_meta comes from
  system_metadata, I think this image.id should be set when we create
  ImageMeta in any case?

  e.g 
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4006

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1647347/+subscriptions