← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1673908] [NEW] Remove support for handling HTTP_X_FORWARDED_PROTO in Glance

 

Public bug reported:

Since Newton, Glance has been using http-proxy-to-wsgi middleware from
oslo.middleware in its pipeline in order to efficiently forward request
headers in case of load balancer style deployments. [0]

The config opt "secure_proxy_ssl_header" was marked deprecated [1].
However the support for this config opt has not been removed yet. [2]

[0]
https://github.com/openstack/glance/blob/48ee8ef4793ed40397613193f09872f474c11abe/etc/glance-api-paste.ini
[1] https://github.com/openstack/glance/blob/7580d817dab87d2b1ef16d2780237ecc4f658699/glance/common/wsgi.py#L302-L311
[2] https://github.com/openstack/glance/blob/7580d817dab87d2b1ef16d2780237ecc4f658699/glance/common/wsgi.py#L933-L936

Remove the support for this opt in Pike cycle.

** Affects: glance
     Importance: Undecided
     Assignee: Dharini Chandrasekar (dharini-chandrasekar)
         Status: New

** Changed in: glance
     Assignee: (unassigned) => Dharini Chandrasekar (dharini-chandrasekar)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1673908

Title:
  Remove support for handling HTTP_X_FORWARDED_PROTO in Glance

Status in Glance:
  New

Bug description:
  Since Newton, Glance has been using http-proxy-to-wsgi middleware from
  oslo.middleware in its pipeline in order to efficiently forward
  request headers in case of load balancer style deployments. [0]

  The config opt "secure_proxy_ssl_header" was marked deprecated [1].
  However the support for this config opt has not been removed yet. [2]

  [0]
  https://github.com/openstack/glance/blob/48ee8ef4793ed40397613193f09872f474c11abe/etc/glance-api-paste.ini
  [1] https://github.com/openstack/glance/blob/7580d817dab87d2b1ef16d2780237ecc4f658699/glance/common/wsgi.py#L302-L311
  [2] https://github.com/openstack/glance/blob/7580d817dab87d2b1ef16d2780237ecc4f658699/glance/common/wsgi.py#L933-L936

  Remove the support for this opt in Pike cycle.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1673908/+subscriptions


Follow ups