yahoo-eng-team team mailing list archive

[OpenStack Infra <1673908@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/glance/+/447172
Committed: https://opendev.org/openstack/glance/commit/8140abe6390818cea2419db31568b51177f44946
Submitter: "Zuul (22348)"
Branch:    master

commit 8140abe6390818cea2419db31568b51177f44946
Author: Dharini Chandrasekar <dharini.chandrasekar@xxxxxxxxx>
Date:   Sat Mar 18 00:34:16 2017 +0000

    Remove secure_proxy_ssl_header opt from Glance
    
    Glance uses http-proxy-to-wsgi middleware from oslo.middleware in
    its pipeline in order to efficiently forward request headers in case
    of load balancer style deployments. Hence, the configuration option
    ``secure_proxy_ssl_header`` was marked as deprecated.
    
    This patch removes the option and the support for it within Glance
    to entirely rely on oslo middleware. This will ensure that the related
    headers set by oslo.middleware:HTTPProxyToWSGI is never modified in
    Glance.
    
    Change-Id: I11d41bb736bbfd90030d88245c11642823e4c400
    Closes-Bug: 1673908


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1673908

Title:
  Remove support for handling HTTP_X_FORWARDED_PROTO in Glance

Status in Glance:
  Fix Released

Bug description:
  Since Newton, Glance has been using http-proxy-to-wsgi middleware from
  oslo.middleware in its pipeline in order to efficiently forward
  request headers in case of load balancer style deployments. [0]

  The config opt "secure_proxy_ssl_header" was marked deprecated [1].
  However the support for this config opt has not been removed yet. [2]

  [0]
  https://github.com/openstack/glance/blob/48ee8ef4793ed40397613193f09872f474c11abe/etc/glance-api-paste.ini
  [1] https://github.com/openstack/glance/blob/7580d817dab87d2b1ef16d2780237ecc4f658699/glance/common/wsgi.py#L302-L311
  [2] https://github.com/openstack/glance/blob/7580d817dab87d2b1ef16d2780237ecc4f658699/glance/common/wsgi.py#L933-L936

  Remove the support for this opt in Pike cycle.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1673908/+subscriptions