yahoo-eng-team team mailing list archive

[OpenStack Infra <1680614@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/454360
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1521049dae51220ac47aeed40ed80aa13ad57036
Submitter: Jenkins
Branch:    master

commit 1521049dae51220ac47aeed40ed80aa13ad57036
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Thu Apr 6 17:47:11 2017 -0400

    Fix test_instance_get_all_by_host
    
    This test was not testing instance_get_all_by_host,
    it was testing _instance_get_all_uuids_by_host,
    which is completely redundant with the same test
    that comes right after it.
    
    ¯\_(ツ)_/¯
    
    Change-Id: Ia0331e3f622f17067bf5900f92b3f8ff2aff966e
    Closes-Bug: #1680614


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1680614

Title:
  test_instance_get_all_by_host does not actually test
  instance_get_all_by_host

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  This unit test:

  https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/tests/unit/db/test_db_api.py#L1170

  Is not actually testing the thing it's supposed to be testing, which
  is:

  https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2528

  It's basically testing the same method that's tested right after it:

  https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/tests/unit/db/test_db_api.py#L1186

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1680614/+subscriptions