yahoo-eng-team team mailing list archive

[OpenStack Infra <1661262@xxxxxxxxxxxxxxxxxx>]

*** This bug is a duplicate of bug 1596829 ***
    https://bugs.launchpad.net/bugs/1596829

Reviewed:  https://review.openstack.org/430249
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=6df0b27ee4fd9d6b23c503427c18f20441bd7c73
Submitter: Jenkins
Branch:    master

commit 6df0b27ee4fd9d6b23c503427c18f20441bd7c73
Author: Gábor Antal <antal@xxxxxxxxxxxxxxx>
Date:   Tue Feb 7 14:22:32 2017 +0100

    Handle log message interpolation by the logger
    
    According to OpenStack Guideline[1], logged string message
    should be interpolated by the logger.
    
    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
    
    Change-Id: I5146c62cfd7e05270c5bf8ebc3ebab3908f1f1ca
    Closes-Bug: #1661262
    Co-Authored-By: Akihiro Motoki <amotoki@xxxxxxxxx>


** Changed in: python-neutronclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1661262

Title:
  String interpolation should be handled by logger

Status in OpenStack Dashboard (Horizon):
  In Progress
Status in python-heatclient:
  Fix Released
Status in python-ironicclient:
  Fix Released
Status in python-neutronclient:
  Fix Released
Status in OpenStack Object Storage (swift):
  Fix Released

Bug description:
  According to [1] guideline, strings should be interpolated by the
  logger.

      # WRONG
      LOG.info(_LI('some message: variable=%s') % variable)

      # RIGHT
      LOG.info(_LI('some message: variable=%s'), variable)

  
  [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1661262/+subscriptions