← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1685930] [NEW] model query hooks cleanup breaks UTs

 

Public bug reported:

The change Ib6c2134d29e1764de627c3355f6cdee789d6301e in neutron cleans
up model query hooks registered after each tests is run. This cleanup
has been added in tests/base.py

In net-bgpvpn, some features rely on those hooks, and UTs for those
features are now broken, as we can see in  :

http://logs.openstack.org/01/458101/2/check/gate-networking-bgpvpn-
python27-ubuntu-xenial/24a6b18/testr_results.html.gz

It appears that if a failing UT is run alone, it passes. However, if the
entire test module is run, then it breaks.

for instance, the test
test_db_list_bgpvpn_filtering_associated_resources passes if it is run
alone, but it fails when it is run after other tests in the same module,
with the following command :

$ ostestr networking_bgpvpn.tests.unit.db.test_db.BgpvpnDBTestCase

by removing the cleanup line, as proposed in
https://review.openstack.org/#/c/459400/ , all UTs are passing in net-
bgpvpn

** Affects: bgpvpn
     Importance: Undecided
         Status: New

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: gate-failure

** Also affects: neutron
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1685930

Title:
  model query hooks cleanup breaks UTs

Status in networking-bgpvpn:
  New
Status in neutron:
  New

Bug description:
  The change Ib6c2134d29e1764de627c3355f6cdee789d6301e in neutron cleans
  up model query hooks registered after each tests is run. This cleanup
  has been added in tests/base.py

  In net-bgpvpn, some features rely on those hooks, and UTs for those
  features are now broken, as we can see in  :

  http://logs.openstack.org/01/458101/2/check/gate-networking-bgpvpn-
  python27-ubuntu-xenial/24a6b18/testr_results.html.gz

  It appears that if a failing UT is run alone, it passes. However, if
  the entire test module is run, then it breaks.

  for instance, the test
  test_db_list_bgpvpn_filtering_associated_resources passes if it is run
  alone, but it fails when it is run after other tests in the same
  module, with the following command :

  $ ostestr networking_bgpvpn.tests.unit.db.test_db.BgpvpnDBTestCase

  by removing the cleanup line, as proposed in
  https://review.openstack.org/#/c/459400/ , all UTs are passing in net-
  bgpvpn

To manage notifications about this bug go to:
https://bugs.launchpad.net/bgpvpn/+bug/1685930/+subscriptions


Follow ups