yahoo-eng-team team mailing list archive

[OpenStack Infra <1685930@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/459585
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=c7211ed718f9b18e186bc66eb460b1526dba40f2
Submitter: Jenkins
Branch:    master

commit c7211ed718f9b18e186bc66eb460b1526dba40f2
Author: Mathieu Rohon <mathieu.rohon@xxxxxxxxx>
Date:   Tue Apr 25 10:44:27 2017 +0200

    Register query hooks at BGPVPNPluginDb object creation
    
    This change also modifies the expected exception raised in tempest
    while testing a delete of a bgpvpn by a regular tenant :
    the Forbidden exception is now raised instead of the NotFound one.
    
    Change-Id: I2aab28f67c096bdb399ca76a2b8d27240823330e
    Closes-bug: 1685930


** Changed in: bgpvpn
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1685930

Title:
  model query hooks cleanup breaks UTs

Status in networking-bgpvpn:
  Fix Released
Status in neutron:
  Invalid

Bug description:
  The change Ib6c2134d29e1764de627c3355f6cdee789d6301e in neutron cleans
  up model query hooks registered after each tests is run. This cleanup
  has been added in tests/base.py

  In net-bgpvpn, some features rely on those hooks, and UTs for those
  features are now broken, as we can see in  :

  http://logs.openstack.org/01/458101/2/check/gate-networking-bgpvpn-
  python27-ubuntu-xenial/24a6b18/testr_results.html.gz

  It appears that if a failing UT is run alone, it passes. However, if
  the entire test module is run, then it breaks.

  for instance, the test
  test_db_list_bgpvpn_filtering_associated_resources passes if it is run
  alone, but it fails when it is run after other tests in the same
  module, with the following command :

  $ ostestr networking_bgpvpn.tests.unit.db.test_db.BgpvpnDBTestCase

  by removing the cleanup line, as proposed in
  https://review.openstack.org/#/c/459400/ , all UTs are passing in net-
  bgpvpn

To manage notifications about this bug go to:
https://bugs.launchpad.net/bgpvpn/+bug/1685930/+subscriptions